Fix imports in x11, mesa_surfaceless & wayland modules#381
Merged
Conversation
mrobinson
approved these changes
Jun 12, 2026
These were referring to the `Context`, `ContextDescriptor` and `NativeContext` types from the crate root using `crate::`, but on unix systems that refers to the types from the `multi` module which is incorrect. Fix these by referring directly to the types defined in modules themselves. Testing: Added sole 'sm-x11' configuration to the CI matrix. Signed-off-by: Mukilan Thiyagarajan <mukilan@igalia.com>
mukilan
force-pushed
the
fix-unix-imports
branch
from
f51d9c4 to
3c7a6bf
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These were referring to the
Context,ContextDescriptorandNativeContexttypes from the crate root usingcrate::, but on unix systems that refers to the types from themultimodule which is incorrect.Fix these by referring directly to the types defined in modules themselves.
Testing: Added sole 'sm-x11' configuration to the CI matrix.