Skip to content

feat: replace python localization generator with codegen#1761

Merged
Bilb merged 4 commits into
devfrom
feat/localization_codegen
Jan 8, 2026
Merged

feat: replace python localization generator with codegen#1761
Bilb merged 4 commits into
devfrom
feat/localization_codegen

Conversation

@Aerilym

@Aerilym Aerilym commented Jan 7, 2026

Copy link
Copy Markdown
Collaborator
  • removed locale json files
  • removed python as a dependency
  • created localization codegen from shared scripts repo

Codegen PR from shared scripts repo: session-foundation/session-shared-scripts#26

removed locale json files

removed python as a dependency

created localization codegen from shared scripts repo
Copilot AI review requested due to automatic review settings January 7, 2026 05:40
@Aerilym Aerilym requested review from Bilb and removed request for Copilot January 7, 2026 05:40
Copilot AI review requested due to automatic review settings January 7, 2026 05:58

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR replaces the Python-based localization generator with a TypeScript codegen solution from the session-shared-scripts repository. The changes remove Python as a dependency, eliminate locale JSON files, and introduce generated TypeScript files for localization.

Key Changes:

  • Removed Python localization tooling and replaced with codegen from session-shared-scripts
  • Moved localization constants and types to ts/localization/generated/ directory
  • Updated all import paths across the codebase to reference the new generated files location
  • Removed Python from CI/CD pipeline and build scripts

Reviewed changes

Copilot reviewed 18 out of 122 changed files in this pull request and generated no comments.

Show a summary per file
File Description
ts/localization/generated/* New auto-generated localization files (constants, locales, english)
ts/localization/localeTools.ts Refactored to use new generated file structure with helper functions
ts/util/, ts/node/, ts/mains/* Updated imports to point to generated constants
ts/components/dialog/user-settings/pages/network/* Changed from using LOCALE_DEFAULTS directly to tr() calls
tools/* Removed all Python localization scripts
package.json Removed Python-related build scripts and dependencies
actions/setup_and_build/action.yml Removed Python setup from CI/CD
.tool-versions Removed Python version specification
.gitignore, .prettierignore, .eslintrc.js Updated to reference new generated directory

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Bilb
Bilb previously approved these changes Jan 7, 2026
Comment thread package.json Outdated
Comment thread ts/localization/generated/english.ts
Comment thread ts/localization/generated/locales.ts Outdated
Comment thread package.json
Comment thread ts/localization/localeTools.ts
Bilb
Bilb previously approved these changes Jan 7, 2026
@Bilb Bilb merged commit c9a2616 into dev Jan 8, 2026
10 checks passed
@Bilb Bilb deleted the feat/localization_codegen branch January 8, 2026 02:41
klodr pushed a commit to klodr/session-desktop that referenced this pull request May 10, 2026
…at/localization_codegen

feat: replace python localization generator with codegen
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants