Draft
Conversation
- replace count() rowCount misuse with real COUNT(*) query (MySQL-safe) - refactor SELECT SQL construction into shared builder - add offset support in query processing (including MySQL offset-without-limit handling) - preserve Model::delete([...]) via static magic dispatch and move implementation to delete_where() - add instance $model->delete() compatibility via __call() -> deleteRow() - add missing assign_attribute() and attributes() instance helpers - update README examples/arguments for working instance delete and offset support
…vior
- add robust SQL builder path with support for offset and safer
pagination assembly
- fix count() to execute a real COUNT(*) query instead of relying on
rowCount() for SELECT
- add ActiveRecord compatibility helpers:
- instance $model->delete() support
- assign_attribute() and attributes()
- static delete dispatch aliases
- introduce PdoFishDateTime and model hydration for
date/datetime/timestamp-like fields
- normalize persistence flows:
- sanitize object-to-array conversion to skip mangled keys
- handle DateTime serialization on save
- improve PK-aware update/delete behavior across methods
- add primary-key auto-detection with per-table cache when model PK is
not declared
- expand dynamic finder support for _and_ compound finders
- add find_one_by_sql() convenience method and improve object hydration
paths for query APIs
- update docs to reflect current ActiveRecord delete and query argument
support
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Necessary bugfixes and features for phishnet.
Sections tested so far: