Merged
Conversation
AGENTS.md with development workflow and commit conventions, CLAUDE.md symlink.
Ruby 3.1/3.2/3.3/3.4 matrix running rspec and rubocop.
Drop runtime deps (httpclient, nokogiri), add rubocop and guard-rspec dev deps, require Ruby >= 3.1, add gem metadata, fix Gemfile.lock gitignore entry.
Remove Coveralls integration and boilerplate comments, add frozen_string_literal pragmas.
Replace httpclient with net/http, use api.weather.gov/alerts JSON endpoint. Add required User-Agent header and area filtering option.
Parse GeoJSON Feature properties instead of XML elements. Map new API fields to existing attribute names.
Accept [lon, lat] arrays from GeoJSON geometry, convert to [lat, lon] internally. Fix Google Maps URL to HTTPS.
Remove nokogiri/httpclient requires, add stdlib requires (json, net/http, time, uri). Add frozen_string_literal to Geocode.
Replace XML fixtures with GeoJSON fixtures, update webmock stubs and assertions for api.weather.gov endpoint.
Add frozen_string_literal pragmas, fix string concatenation indentation, freeze mutable constant, disable Documentation cop.
Raise HttpError on non-2xx API responses instead of silently returning empty results. Derive SSL from URI scheme. Handle MultiPolygon geometry type. Drop url option (use area instead).
Use 44 real alerts from AR, MO, AK covering polygons, null geometries, VTEC, geocodes, and varied severity/urgency/ certainty values.
Remove defunct badges, add GitHub Actions badge, update usage examples for new API, document zero runtime dependencies.
Google Static Maps requires billing and is unrelated to NWS alerts. Callers can use coordinates or to_wkt with any mapping library.
houndci-bot
reviewed
Mar 7, 2026
| stub_request(:get, 'https://api.weather.gov/alerts/active?area=OK') | ||
| .to_return(status: 200, body: json, headers: {}) | ||
|
|
||
| client = Gull::Client.new(area: 'OK') |
Collaborator
There was a problem hiding this comment.
Style/StringLiterals: Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.