Merged
Conversation
Convert instance parse method to self.parse class method, matching the pattern used by other item classes. Apply AttributeFormatter for boolean formatting and remove M3u8 module inclusion.
Convert instance parse method to self.parse class method with private class helpers for base attributes, interstitials, and client attributes. Replace include M3u8 with extend M3u8.
Merge instance parse logic into self.parse with private class method helpers. Replace include M3u8 with extend M3u8.
Move parsing logic from Reader into SegmentItem.parse class method, matching the pattern used by other item classes.
Replace manual byterange_format with quoted_format using AttributeFormatter, switching to array-based formatted_attributes.
Replace manual duration_format, uri_format, and byterange_format helpers with unquoted_format and quoted_format from AttributeFormatter.
Replace repeated gsub tag-prefix patterns with a single tag_value method that splits on the first colon.
Convert proc blocks to lambda syntax for consistency. Zero-arg procs become lambdas that accept and ignore the line argument.
Inline the last parse_yes_no usage and remove include M3u8, since all item parsing now uses class-level parse methods.
Add YARD annotations to all public methods including .build, .codecs, .read, #write, #to_s, #valid?, #errors, #live?, #master?, #freeze, #duration, and all convenience accessors.
Add YARD annotations to attrs, .parse, #to_s, #resolution, and #codecs methods.
Add YARD annotations to Encryptable, KeyItem, SessionKeyItem, and MediaItem classes.
Add YARD annotations to MapItem, DateRangeItem, ByteRange, TimeItem, DiscontinuityItem, GapItem, and BitrateItem.
Add YARD annotations to PartItem, PartInfItem, ServerControlItem, PreloadHintItem, RenditionReportItem, and SkipItem.
Add YARD annotations to PlaybackStart, SessionDataItem, ContentSteeringItem, DefineItem, Codecs, Reader, Writer, and Builder.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.