First draft implementation for scheme handler registry#405
Draft
MMulthaupt wants to merge 12 commits intomasterfrom
Draft
First draft implementation for scheme handler registry#405MMulthaupt wants to merge 12 commits intomasterfrom
MMulthaupt wants to merge 12 commits intomasterfrom
Conversation
Member
|
Currently going through internal testing. |
![hound[bot]](https://avatars.githubusercontent.com/in/3598?s=60&v=4){kind=small}
|
|
||
| func (u *Updater) Prepare(deploymentConfigURL string) { | ||
| log.Infof("Downloading deployment config from \"%s\".", deploymentConfigURL) | ||
| func (u *Updater) ObtainDeploymentConfig(deploymentConfigURL string) { |
There was a problem hiding this comment.
exported method Updater.ObtainDeploymentConfig should have comment or be unexported
| Execution ExecutionConfig `json:"Execution,omitempty"` | ||
| } | ||
|
|
||
| type SchemeHandler struct { |
There was a problem hiding this comment.
exported type SchemeHandler should have comment or be unexported
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See TODOs in code.
Additional TODOs:
SchemeHandlersmight be better suited to be an array.systemuricould then take a[]stringof arguments to have more information to go by if ever needed. We lose nothing in the process andSchemeHandlers.ArgumentLinecould be renamed toSchemeHandlers.Arguments.See also:
https://learn.microsoft.com/en-us/previous-versions/windows/internet-explorer/ie-developer/platform-apis/aa767914(v=vs.85)