1.0.1#12
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR addresses Issue #11 by fixing silent-mode Parameter 5 parsing so multiple comma-separated item IDs are correctly recognized when Jamf passes them as one quoted CSV string, while keeping quote normalization robust under non-UTF locales.
Changes:
- Add helper functions to trim outer straight/smart quotes and normalize the full CSV input before splitting.
- Update silent-mode CSV parsing to split reliably on commas using Zsh’s split flags instead of relying on
IFS. - Bump documented version references to
1.0.1b3and update related documentation text.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| SYM-Lite.zsh | Adds quote/CSV normalization helpers and fixes silent-mode CSV splitting for multi-item Parameter 5 inputs; bumps scriptVersion/history. |
| README.md | Updates displayed version and clarifies how silent-mode quote/CSV normalization works. |
| CHANGELOG.md | Records the 1.0.1b3 changes corresponding to the silent-mode parsing fix. |
| .github/ISSUE_TEMPLATE/bug_report.yml | Updates the bug report “version tested” placeholder text. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses Bug Report #11.