Skip to content

feat: extend minigrades V2 features with change-grade and info commands - #73

Closed
berkevnl wants to merge 1 commit into
seyyah:mainfrom
berkevnl:main
Closed

feat: extend minigrades V2 features with change-grade and info commands#73
berkevnl wants to merge 1 commit into
seyyah:mainfrom
berkevnl:main

Conversation

@berkevnl

Copy link
Copy Markdown
Collaborator

🚀 MiniGrades V2: Advanced Commands & Floating Point Precision

🛠 What was changed?

I have expanded the minigrades V2 problem set by integrating new features and refining the existing standards. The additional architectural and functional updates include:

  • New Commands: Integrated change-grade (for granular grade updates) and info (for detailed student data visualization) commands.
  • Precision Standard: Implemented a strict 2-decimal floating point requirement (e.g., 85.00) for all average calculations across list, report, and info commands.
  • Escalated Test Suite: Expanded test-v2.sh to approximately 400 lines, covering 38 individual test cases including edge cases, boundary conditions, and output format validation.
  • SPEC Refinement: Updated SPEC-v2.txt to be more deterministic, ensuring character-perfect requirements for automated benchmarking.
  • Documentation: Updated walkthrough.md following the professional benchmark log schema to maintain a clear engineering audit trail.

❓ Why was it changed?

  • Granular Data Management: The previous version lacked the ability to modify existing records. Adding change-grade allows for more complex state management without compromising data integrity.
  • Increased Benchmark Difficulty: These updates are designed to challenge AI models (like Gemini) not just on basic logic, but on their ability to handle precise mathematical formatting and strict output constraints.
  • System Reliability: By increasing the test density, I ensured that the core "student management" logic remains robust even as new features are added, preventing regression.

✅ Did I test it?

  • Local Environment: Verified all 38 test cases on Linux using the new test-v2.sh script (37/38 PASSED).
  • Backward Compatibility: Confirmed that all V1 core functions (init, add, list, delete) remain fully functional within the new architecture.

@berkevnl

Copy link
Copy Markdown
Collaborator Author

The CI/CD pipeline failed due to internal GitHub Actions issues (Resource not accessible and SyntaxError in validate-problem). These errors are unrelated to the code changes in this PR. As the contributor, I have verified the code locally and it's ready for review.

@seyyah

seyyah commented Apr 21, 2026

Copy link
Copy Markdown
Owner

Bu PR maalesef projenin AGENT.md belgesindeki kurallara uymadığı için kapatılıyor. Lütfen şartları inceleyerek düzeltmeleri yaptıktan sonra yeni bir PR açın.

This PR is being closed because it violates project conventions:

  • PR title "feat: extend minigrades V2 features with change-grade and info commands" inside invalid format. Title must strictly follow '[component] Brief description' format (e.g., '[problem] Add minipomodoro').

Please review AGENT.md (PR guidelines & New problem checklist) and submit a new PR once the structure matches the conventions.

@seyyah seyyah closed this Apr 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants