fix: [PR-1680] parse correct API field names for v2/images#251
Merged
sigmachirality merged 3 commits intomainfrom Feb 18, 2026
Merged
Conversation
…conflict in images upload
Three bugs fixed in `sf images upload`:
1. `partResponse.data.upload_url` → `.url`: the v2/images/{id}/parts endpoint
returns `url`, not `upload_url` as the schema declared.
2. `sha256_hash` → `sha256`: the v2/images/{id}/complete endpoint expects the
field named `sha256`, not `sha256_hash` as the schema declared. Schema updated
to match both.
3. isFullwidthCodePoint runtime crash: bun's symlink layout caused Node.js (v24)
to resolve `is-fullwidth-code-point` to v5.1.0 (ESM-only) from within
`cli-progress`'s nested `string-width@4.2.3` (CJS). When CJS require()s an
ESM module in Node 24 it gets the module namespace object, not the default
export, so `isFullwidthCodePoint(code)` threw "not a function". Fixed by
pinning `is-fullwidth-code-point` to 3.0.0 via package.json overrides and
a clean bun install.
Also improves the complete-upload error message to use `completeResponse.error`
(already parsed by openapi-fetch) instead of re-reading the consumed response body.
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
|
Review changes with Changed Files
|
andreaanez
changed the title
v2 images API
sigmachirality
changed the title
v2 images APIv2/images
The v2 API field names (sha256, url) differ from the generated schema (sha256_hash, upload_url). Rather than modifying the generated schema, the next commit switches sf images upload to raw fetch with hardcoded types so it is not coupled to schema.ts. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
sigmachirality
force-pushed
the
fix/images-upload-api-field-names-and-dep-conflict
branch
from
83da58a to
04ef1de
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
urlnotupload_url:v2/images/{id}/partsreturnsurlin the response — schema and upload code updated to matchsha256notsha256_hash:v2/images/{id}/completeexpectssha256in the request body — schema and upload code updated to matchisFullwidthCodePoint is not a functioncrash: bun's symlink layout caused Node.js v24 to resolveis-fullwidth-code-pointto v5.1.0 (ESM-only) from withincli-progress'sstring-width@4.2.3(CJS). When CJSrequire()s an ESM module in Node 24, it returns the module namespace object rather than the default export, causingisFullwidthCodePoint(code)to throw. Fixed by pinningis-fullwidth-code-point@3.0.0viaoverridesinpackage.json.Test plan
sf images upload -f <file> --name <name>completes successfully end-to-end🤖 Generated with Claude Code