Ported ngramrr here. Remove ngramrr dependency, add tau to DESCRIPTION#10
Open
chainsawriot wants to merge 1 commit intosfeuerriegel:masterfrom
Open
Ported ngramrr here. Remove ngramrr dependency, add tau to DESCRIPTION#10chainsawriot wants to merge 1 commit intosfeuerriegel:masterfrom
chainsawriot wants to merge 1 commit intosfeuerriegel:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello. I am the author of ngramrr. I have a plan to remove ngramrr from CRAN because there are actually better, highly efficient ngram tokenizers out there (e.g.
tokenizers). As your package is the only package using ngramrr, I think I shouldn't break your package. As an interim solution, I have ported all functions from ngramrr to your package. But I think in the long run, it would be good for you to use something else, e.g.tokenizers. I will keep ngramrr on CRAN, until you have updated this package on CRAN.BTW, on my machine, I can't pass one of the unit tests.
test.analyzeSentiment.R:80From my understanding of F1 score, the F1 score for that case (4TP, 0FP, 0TN, 0FN) should be 1, not 0.