Skip to content

fix(preview): migrate full-width preference - #325

Closed
PathGao wants to merge 1 commit into
sftwrdotdev:feat/preview-width-shortcutsfrom
PathGao:fix/migrate-preview-full-width-preference
Closed

fix(preview): migrate full-width preference#325
PathGao wants to merge 1 commit into
sftwrdotdev:feat/preview-width-shortcutsfrom
PathGao:fix/migrate-preview-full-width-preference

Conversation

@PathGao

@PathGao PathGao commented Jul 31, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • Moves Full width persistence from the generic isFullWidth key to preview.fullWidth.
  • Preserves existing users’ setting when the new key is absent; a valid new-key value wins when both exist.
  • Removes the legacy key after the current state is persisted.

Validation

  • npm run check
  • npm test (149 passing)
  • npm run build
  • cargo test (25 passing)

Stack

Closes #263. This PR follows #320#321#322#323#324.

Post-deploy monitoring

  • Verify current Full width users retain their selection across the first upgraded launch.
  • Verify a changed Full width selection persists to the dedicated key.

@PathGao

PathGao commented Jul 31, 2026

Copy link
Copy Markdown
Collaborator Author

@alecdotdev #325 is the fifth PR in the #263 stack. It migrates the legacy full-width preference while preserving existing users’ selection. It follows #324.

@PathGao

PathGao commented Jul 31, 2026

Copy link
Copy Markdown
Collaborator Author

@alecdotdev All five checks are now green on #325. The #263 stack is ready in order: #320#321#322#323#324#325; merging #325 will close #263 automatically.

@PathGao
PathGao force-pushed the fix/migrate-preview-full-width-preference branch from fbed430 to ce48040 Compare August 2, 2026 04:01
@PathGao
PathGao force-pushed the fix/migrate-preview-full-width-preference branch from ce48040 to 394789d Compare August 2, 2026 05:44
@PathGao
PathGao changed the base branch from master to feat/preview-width-shortcuts August 2, 2026 05:45
@PathGao

PathGao commented Aug 2, 2026

Copy link
Copy Markdown
Collaborator Author

Superseded by native Stack PR #350 (Stack #353). Closing this fork-head PR so #350 is the active review path.

@PathGao PathGao closed this Aug 2, 2026
@PathGao
PathGao deleted the fix/migrate-preview-full-width-preference branch August 2, 2026 08:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature]: Preview Mode Display Width Adjustment

1 participant