fix(preview): persist task checkbox changes - #327
Closed
PathGao wants to merge 1 commit into
Closed
Conversation
Collaborator
Author
|
@alecdotdev This follows #326 in the current chain. I verified the fix in an isolated macOS release bundle: accessibility activation changed the preview checkbox and persisted |
This was referenced Jul 31, 2026
PathGao
force-pushed
the
fix/preview-checkbox-change-event
branch
from
August 2, 2026 04:02
d631c73 to
fd5f46e
Compare
PathGao
force-pushed
the
fix/preview-checkbox-change-event
branch
from
August 2, 2026 05:44
fd5f46e to
c627e7d
Compare
Collaborator
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Preview checklist changes now follow the checkbox's committed state, so mouse, keyboard, and accessibility input all write the intended Markdown marker. The former click handler inferred a new state and could leave the file unchanged when the input provider had already updated the native control.
Fixes #148.
Validation
npm run checknpm testcargo testMarkpad PR Test.app; clicking a preview checkbox changed it from unchecked to checked and wrote- [x]to disk.Merge order
This is the next commit in the current chain and should merge after #326.