add swiglu oai quant ops - #575
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces a new implementation of the swiglu_oai activation function with optional per-row int8 quantization for Ascend NPU, supporting both dense MLP and MoE grouped modes. The review feedback correctly identifies a critical bug where the undefined kernel _swiglu_oai_quant_kernel_grouped is called instead of _swiglu_oai_quant_kernel_moe.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
| f"got {group_list.dtype}" | ||
| ) | ||
|
|
||
| _swiglu_oai_quant_kernel_grouped[(num_vectorcore,)]( |
There was a problem hiding this comment.
The kernel _swiglu_oai_quant_kernel_grouped is not defined or imported in this file. It should be _swiglu_oai_quant_kernel_moe.
| _swiglu_oai_quant_kernel_grouped[(num_vectorcore,)]( | |
| _swiglu_oai_quant_kernel_moe[(num_vectorcore,)]( |
5ef051f to
bbad098
Compare
1 participant
Uh oh!
There was an error while loading. Please reload this page.