feat: add non-greedy MTP sampling kernels - #623
Open
cl-vv-h wants to merge 1 commit into
Open
Conversation
Contributor
|
Caution The consumer version of Gemini Code Assist on GitHub has been sunset. All code review activity has officially ceased. |
cl-vv-h
marked this pull request as draft
July 27, 2026 06:26
cl-vv-h
marked this pull request as ready for review
July 27, 2026 06:27
Contributor
|
Caution The consumer version of Gemini Code Assist on GitHub has been sunset. All code review activity has officially ceased. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
NPU MTP verification currently supports greedy verification, but non-greedy
requests do not have a corresponding probability-sampling path. This can make
temperature,top_k, andtop_pineffective during speculativeverification.
With GLM-4.7-Flash on GPQA, enabling non-greedy MTP previously reduced the
observed accuracy from approximately ~70% to ~50%.
Modifications
tree_topk=1linear chains:xwithmin(1, p(x) / q(x));relu(p - q)after the first rejection;vocabularies.
sgl_kernel_npu.sample.cur_prob_rowexplicitly typed asint64for Triton SSA type consistency.
Supported Scope
tree_topk >= 1.tree_topk=1linear chains.Tests
The tests cover probability renormalization, general-tree target-only
sampling, classic rejection chains, early rejection, all-accepted requests,
acceptance thresholds, and vocabularies up to 151552 tokens.
Accuracy
Model:
GLM-4.7-FlashDataset:
GPQA_Diamondtree_topk=1)Performance
Checklist