fix: start gate, cinema UX, 100× speed, and Rectangle gates#7
Merged
Conversation
Require an explicit Start click before training runs, collapse secondary panels by default, fix overlapping chrome and WASD/demo key conflicts, promote a live champion when the leader crashes, make high sim speeds actually scale, add a Rays cinema toggle, and bake the hand-tuned Rectangle checkpoint layout into the preset.
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (9)
📝 WalkthroughWalkthroughThe update adds an explicit Start overlay and boot gate, introduces a Rays presentation toggle, revises worker scheduling and snapshot behavior, changes Rectangle tracks to five checkpoints, and adjusts panel and overlay layouts. ChangesExplicit startup gate
Presentation controls
Worker execution and fitness
Rectangle track geometry
Overlay and panel layout
Estimated code review effort: 4 (Complex) | ~60 minutes Sequence Diagram(s)sequenceDiagram
participant User
participant StartOverlay
participant Main
participant Worker
User->>StartOverlay: Click Start Training
StartOverlay->>Main: Set pending start and clear awaiting gate
Main->>Worker: Begin simulation
Main->>Worker: Re-assert pause state
Worker-->>Main: Send preview and simulation snapshots
sequenceDiagram
participant MainThread
participant SimWorker
participant MessageChannel
MainThread->>SimWorker: Set simulation speed
SimWorker->>MessageChannel: Schedule tick
MessageChannel->>SimWorker: Deliver tick
SimWorker->>SimWorker: Step within wall-time budget
SimWorker-->>MainThread: Post cadence-controlled snapshot
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
End-to-end UI/UX and simulation fixes validated with agent-browser.
Start gate & first paint
__pendingStart.performBegin/ 500 cars) is deferred until Start so the CTA stays responsive.Layout & panels
<details>panels (training tuning, import/export, more actions, brain saves) closed by default.#ab-hudleaking empty chips:display: flexwas overriding the HTMLhiddenattribute.Keyboard / cinema controls
?rays=0).Champion handoff after crash
Sim speed (100×)
MAX_STEPS=60dropped most of the high-speed accumulator; 20ms tick budget +setTimeout(0)capped throughput.Rectangle track
roadEditor.jsfallback defaults.Test plan
#ab-hudchildren not visible when A/B off; visible when onaria-pressed/ stateSummary by CodeRabbit
New Features
Rshortcut.Improvements
Bug Fixes