REFACTOR: Shell uses TTY reference#232
Draft
riblanc wants to merge 1 commit into
Draft
Conversation
Merge ProtectionsYour pull request matches the following merge protections and will not be merged until they are valid. 🔴 ⛓️ Depends-On RequirementsWaiting for
This rule is failing.Requirement based on the presence of
|
riblanc
force-pushed
the
ri/tty/serial
branch
from
977d8c4 to
a37002d
Compare
riblanc
force-pushed
the
ri/shell/tty-ref
branch
from
71644d1 to
ac0a7dd
Compare
riblanc
force-pushed
the
ri/tty/serial
branch
from
a37002d to
594ee3c
Compare
riblanc
force-pushed
the
ri/shell/tty-ref
branch
from
ac0a7dd to
3ae821f
Compare
riblanc
force-pushed
the
ri/tty/serial
branch
from
594ee3c to
5cb4119
Compare
riblanc
force-pushed
the
ri/shell/tty-ref
branch
from
3ae821f to
be188d0
Compare
riblanc
force-pushed
the
ri/tty/serial
branch
2 times, most recently
from
a240525 to
cdb6d30
Compare
riblanc
force-pushed
the
ri/shell/tty-ref
branch
from
be188d0 to
4ab4bf4
Compare
riblanc
changed the title
riblanc
force-pushed
the
ri/shell/tty-ref
branch
from
4ab4bf4 to
1ae9dbd
Compare
riblanc
force-pushed
the
ri/shell/tty-ref
branch
from
1ae9dbd to
8236d2f
Compare
Refactor Shell.zig: - Replace separate reader/writer fields with a single tty: *TtyStruct - reader() and writer() are now inline computed getters - All existing shell.writer/reader usage updated to shell.writer()/reader() Updated call sites: - kernel.zig: pass tty.get_tty() instead of reader/writer - ci.zig: pass ttyS0's TtyStruct pointer - ci/shell.zig, ci/builtins.zig: shell.writer() calls - default/shell.zig, default/builtins.zig: shell.writer() calls - utils.zig: shell.writer() calls
riblanc
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactor Shell.zig:
Updated calls:
Depends-on: #231