Skip to content

Update api key and secret key in the new api_keypair table (for cs version >= 4.23)#221

Merged
sureshanaparti merged 2 commits into
sofia-labfrom
api-keypair-update
May 21, 2026
Merged

Update api key and secret key in the new api_keypair table (for cs version >= 4.23)#221
sureshanaparti merged 2 commits into
sofia-labfrom
api-keypair-update

Conversation

@sureshanaparti
Copy link
Copy Markdown
Member

@sureshanaparti sureshanaparti commented May 20, 2026

Update api key and secret key in the new api_keypair table. This is needed for 4.23.0 onwards, as the API key pair added to new table.

Ref Upstream PR change here: https://github.com/apache/cloudstack/pull/9504/changes#diff-c2a347e8868908a473213b79695fd81420bee5f97f09c1e1c0d488529e17c80e

Copy link
Copy Markdown
Member

@kiranchavala kiranchavala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vishesh92
Copy link
Copy Markdown
Member

Do we need a cloudstack version check?

Comment thread Ansible/roles/cloudstack-manager/tasks/preconfig_globalsettings.yml
@sureshanaparti sureshanaparti changed the title Update api key and secret key in the new api_keypair table Update api key and secret key in the new api_keypair table (for cs version >= 4.23) May 20, 2026
Copy link
Copy Markdown
Member

@weizhouapache weizhouapache left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code lgtm

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the Ansible CloudStack manager preconfiguration to handle the CloudStack 4.23+ schema change where API keypairs are stored in the new cloud.api_keypair table rather than cloud.user.

Changes:

  • Gate the legacy cloud.user API key update to CloudStack versions < 4.23.
  • Add a new CloudStack >= 4.23 task to update the admin API keypair in cloud.api_keypair.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread Ansible/roles/cloudstack-manager/tasks/preconfig_globalsettings.yml
Copy link
Copy Markdown
Member

@vishesh92 vishesh92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@weizhouapache
Copy link
Copy Markdown
Member

@sureshanaparti
the target branch should be master

@sureshanaparti sureshanaparti merged commit d7842a7 into sofia-lab May 21, 2026
1 check passed
@sureshanaparti sureshanaparti deleted the api-keypair-update branch May 21, 2026 11:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants