extensions: randr: fix missing export and errors#173
Open
paulapatience wants to merge 1 commit intosharplispers:masterfrom
Open
extensions: randr: fix missing export and errors#173paulapatience wants to merge 1 commit intosharplispers:masterfrom
paulapatience wants to merge 1 commit intosharplispers:masterfrom
Conversation
8ef475b to
6fa7bb8
Compare
RR-SET-CRTC-CONFIG was unexported, and the extension's errors (and conditions) were undefined. Additionally, conform the order of the exports and function definitions to that of the opcodes, unexport some undefined functions, wrap some overlong lines, and clean up some comments and whitespace.
6fa7bb8 to
33204b6
Compare
Member
|
I think that the right convention is the one from the core module (which is documented), that is foo-error. Extensions should be adjusted to follow it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
RR-SET-CRTC-CONFIG was unexported, and the extension's errors (and conditions) were undefined.
Additionally, conform the order of the exports and function definitions to that of the opcodes, unexport some undefined functions, wrap some overlong lines, and clean up some comments and whitespace.
I am unsure of the naming convention for errors and conditions (and other symbols in the extensions in general). Various conventions exist in the codebase, e.g., FOO-ERROR in
input.lisp, BAD-FOO in a subpackage inextensions/glx.lisp(my preference), and prefixing the errors with a common string (related to the extension name) inextensions/xvidmode.lisp(which is also the convention ofextensions/randr.lisp– though not faithfully adhered to – and thus the one I followed in this PR). In #172 I removed the RR- prefix from +RR-CONNECTION+ because first, it was missing from the CONNECTION type, and second, in the RandR specification it has no prefix (unlikeRRCONFIGSTATUS, for instance). However, perhaps the extensions should prefix all of their symbols (consistently) to avoid conflicting with each other and with the base library. This would be done, if at all, in a future PR, of course.