feat(domain): hardened entity model, rich domain behavior, BigDecimal, financials, and constructor injection (Phase 2A) - #4
Merged
Conversation
shashankch
commented
Jul 31, 2026
shashankch
commented
Owner
- Replaced Double with BigDecimal (precision = 19, scale = 4) for monetary fields in User and Transaction entities
- Implemented rich domain methods User.debit() and User.credit() encapsulating balance invariants
- Added audit timestamps (@CreationTimestamp, @UpdateTimestamp) and optimistic locking (@Version) to User
- Added TransactionStatus and TransactionType enums
- Added JPA @manytoone relationships between Transaction and User with denormalized UPI strings
- Added UUID referenceId auto-generation on Transaction (@PrePersist)
- Refactored UserService, TransactionService, UserController, and TransactionController to constructor injection
- Added unit test suite for User domain logic and Transaction reference ID (UserTest, TransactionTest)
- Added ADR-001 (BigDecimal), ADR-002 (Constructor injection), ADR-003 (Rich Domain Model)
- Updated ARCHITECTURE.md, ROADMAP.md, CHANGELOG.md, and README.md
… financials, and constructor injection (Phase 2A) - Replaced Double with BigDecimal (precision = 19, scale = 4) for monetary fields in User and Transaction entities - Implemented rich domain methods User.debit() and User.credit() encapsulating balance invariants - Added audit timestamps (@CreationTimestamp, @UpdateTimestamp) and optimistic locking (@Version) to User - Added TransactionStatus and TransactionType enums - Added JPA @manytoone relationships between Transaction and User with denormalized UPI strings - Added UUID referenceId auto-generation on Transaction (@PrePersist) - Refactored UserService, TransactionService, UserController, and TransactionController to constructor injection - Added unit test suite for User domain logic and Transaction reference ID (UserTest, TransactionTest) - Added ADR-001 (BigDecimal), ADR-002 (Constructor injection), ADR-003 (Rich Domain Model) - Updated ARCHITECTURE.md, ROADMAP.md, CHANGELOG.md, and README.md
shashankch
marked this pull request as draft
July 31, 2026 19:09
shashankch
marked this pull request as ready for review
July 31, 2026 20:16
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.