ltlmt: skip sat check for assumptions that contain LTL#4
Open
lou1306 wants to merge 1 commit intodevelop-shaunfrom
Open
ltlmt: skip sat check for assumptions that contain LTL#4lou1306 wants to merge 1 commit intodevelop-shaunfrom
lou1306 wants to merge 1 commit intodevelop-shaunfrom
Conversation
Collaborator
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The LTLMT workflow does a simple check at the beginning: if the assumptions are unsatisfiable, then the specification is vacuously realisable by any controller.
However, if any of the assumptions contain LTL modalities, the sat() check will fail with
NotImplementedError. In this case, rather than just erroring out, I think we should assume that the assumptions are satisfiable and attempt synthesis.