Skip to content

Improve CI #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
shawju merged 5 commits into from
Sep 16, 2021
Merged

Improve CI #5

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
bb1f6d3
Improve CI
shawju Sep 16, 2021
eb80139
Update .github/workflows/node.js.yml
shawju Sep 16, 2021
387f8d6
Update workflow
shawju Sep 16, 2021
6a9c974
Update .github/workflows/node.js.yml
shawju Sep 16, 2021
beb0fb0
Update .github/workflows/node.js.yml
shawju Sep 16, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 21 additions & 10 deletions .github/workflows/node.js.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,21 +11,32 @@ on:

jobs:
build:

runs-on: ubuntu-latest

steps:
- uses: actions/checkout@v2
- name: npm install and build webpack
run: |
npm install
npm run build

test:
- uses: actions/upload-artifact@master
with:
needs: build
path: public/
strategy:
matrix:
node-version: [12.x, 14.x, 16.x]
# See supported Node.js release schedule at https://nodejs.org/en/about/releases/

os: [ubuntu-latest, windows-2016]
node-version: [12.x, 14.x]
steps:
- uses: actions/checkout@v2
- name: Use Node.js ${{ matrix.node-version }}
uses: actions/setup-node@v2
uses: actions/setup-node@v1
with:
Copy link
Copy Markdown
Contributor

@github-learning-lab github-learning-lab bot Sep 16, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can commit this suggestion directly.

Suggested change
with:
- uses: actions/download-artifact@main
with:
name: webpack artifacts
path: public
- name: npm install, and test

Copy link
Copy Markdown
Contributor

@github-learning-lab github-learning-lab bot Sep 16, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can commit this suggestion directly.

Suggested change
with:
- uses: actions/download-artifact@main
with:
name: webpack artifacts
path: public
- name: npm install, and test

node-version: ${{ matrix.node-version }}
cache: 'npm'
- run: npm ci
- run: npm run build --if-present
- run: npm test
- name: npm install, and test
run: |
npm install
npm test
env:
CI: true