fix: deduplicate incoming messages to prevent multiple auto-replies#85
Open
octo-patch wants to merge 1 commit into
Open
fix: deduplicate incoming messages to prevent multiple auto-replies#85octo-patch wants to merge 1 commit into
octo-patch wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #75
Problem
The same seller message was being read multiple times (with different timestamps in some cases), causing the bot to generate and send multiple replies for a single incoming message. This resulted in buyers receiving duplicate or repeated responses.
Solution
Add message deduplication using the
messageIdextracted from thereminderUrlfield in each message:__init__, addedself.processed_message_ids(aset) andself.max_processed_ids(configurable viaMAX_PROCESSED_IDSenv var, default 1000) to track recently-processed message IDs.handle_message, after extractingurl_info, extractmessageIdfrom the URL and check it againstself.processed_message_idsbefore processing.max_processed_idsentries.Testing
messageIdparameter is present inreminderUrlfor standard chat messages.messageId(they are still processed normally).