fix: aggregate all APs for the same SSID in NetworkManager backend - #124
fix: aggregate all APs for the same SSID in NetworkManager backend#124google-labs-jules[bot] wants to merge 1 commit into
Conversation
Refactor `BuildNetworkList` in the `networkmanager` backend to correctly
aggregate multiple Access Points (e.g., dual-band 2.4GHz/5GHz) for the
same SSID into a single `wifi.Connection` object.
Key changes:
- Pre-process `knownConnections` into a map (`SSID` -> `Connection`) to
replace the O(N) nested loop lookup with an O(1) map lookup, improving
performance.
- Simplify the AP processing loop:
- Construct a base `wifi.Connection` for every AP immediately.
- Populate metadata (IsKnown, AutoConnect, etc.) using the pre-built map.
- Use `AddAccessPoint` to merge the new AP into an existing connection
in `uniqueConns`, or insert it as a new entry.
- Remove the logic that previously discarded weaker APs, ensuring all
detected frequencies are listed.
A new test case `TestBuildNetworkList_AggregatesAPs` verifies that
multiple APs with different strengths are correctly aggregated.
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
Aggregate all APs for the same SSID in NetworkManager backend and refactor BuildNetworkList for clarity and performance.
PR created automatically by Jules for task 10792432200678381539 started by @shazow