[C] Task 1: Notch Bar — adaptive shape, synthetic notch, hover affordance

[sheepxux]

Summary

Task 1 complete: collapsed Notch Bar with full design polish.

Visual

• Adaptive layout: notched displays use the real notch dimensions; no-notch displays render a synthetic black notch flush with the screen top.
• Continuous-curvature ("squircle") rounded bottom corners.
• Notched bar protrudes 7pt below the hardware notch (Dynamic Island feel).
• Synthetic notch fills the OS menu-bar height exactly (uses frame.maxY - visibleFrame.maxY for accurate measurement).

Hover affordance

• Width grows by 50pt (capsule) / 30pt (notched) with spring animation.
• Capsule drops 8pt below the menu bar on hover.
• Status dot + count fade in on hover (idle = clean silhouette).
• Pointer cursor changes to .pointingHand.
• System NSWindow shadow toggles on for hover (Apple-native, no compositor seams).

Adaptivity

• Re-measures on didChangeScreenParametersNotification — display swap, "Larger Text", scale changes are all auto-handled.
• Notched ⇄ synthetic-notch flips automatically when window moves to a different display.

Architecture

• Split into IslandApp (exec, @main + AppDelegate) + IslandAppLib (library, all view code) so SwiftUI Previews work under Xcode 26's ENABLE_DEBUG_DYLIB requirement.
• All UI consumes TaskStore from IslandCore per the contract.

Test plan

• Open in Xcode 26+ on macOS 14+
• Switch scheme to IslandApp → ⌘R
• Confirm: bar appears at top of screen, vertically centered in menu bar
• Hover: bar widens, content fades in, shadow appears, cursor changes
• Leave hover: bar shrinks back, shadow + content disappear
• Switch scheme to IslandAppLib → open NotchBarView.swift → Canvas Resume
• Confirm: 5-state previews render correctly for both notched and capsule modes

---

Summary by cubic

Builds the collapsed Notch Bar with adaptive/synthetic notch, hover affordance, and a single‑window bar→panel morph backed by live IslandCore data. Adds Settings, banner notifications, and a release pipeline; rebrands the app to “Dev Island” with a new icon, updated bundle/Cask ids, and a bundle filename fix so Finder shows “Dev Island” everywhere.

• New Features

  • Adaptive bar: real‑notch cutout; no‑notch screens get a flat‑top synthetic notch; auto‑repositions on screen changes.
  • Hover affordance: widens, pointer cursor, native NSWindow shadow.
  • Panel: click bar to expand; hover‑out/Esc/click‑outside collapses; task list with “Connect Service” footer.
  • Data + notifications: live Manus tasks via ManusAPIClient with Hummingbird webhook + tunnel and 60s polling fallback; macOS banners for running→completed and any→waiting; taps open task URLs; enabled only in bundled .app builds.
  • Settings: Manus API key connect/disconnect (Keychain + live validate), Launch at Login via SMAppService, Quit; gear opens it; API key placeholder updated to sk‑….
  • Single window + safety + polish: one borderless IslandWindow morphs a shared NotchPanelShape; transparent areas click‑through via cursor‑tracked ignoresMouseEvents; 250ms synced color transitions; bar dims to idle gray when .disconnected/.reconnecting (.degraded keeps live colors).

• Release & Build

  • Branding: app name “Dev Island”; bundle id app.devisland.Island; new AppIcon; Homebrew Cask renamed to dev-island; VERSION bumped to 0.1.1; Keychain/UserDefaults namespaces updated (pre‑0.1.1 installs may need to re‑enter the API key); bundle filename now “Dev Island.app” and used across scripts/workflow/Cask so Finder shows the correct name everywhere.
  • Release workflow: tag‑triggered GitHub Actions builds → codesigns → notarizes → staples → uploads both Dev-Island.zip and Dev-Island-<VERSION>.zip; prints sha256 for the Cask.
  • SPM → .app: scripts/build-app.sh wraps the executable; App icon bundled; Info.plist added; build output ignored in build/.
  • Homebrew Cask draft under dist/homebrew-island; Cask declares depends_on cask: "cloudflared".
  • cloudflared resolution at runtime: /opt/homebrew/bin → /usr/local/bin → $PATH; falls back to 60s polling if missing.
  • CI hardening: macOS 15 (Swift 6), correct .p12 import flags, longer notarize timeouts, contents: write permissions; previews guarded with #if PREVIEWS && DEBUG.

^{Written for commit a635299. Summary will update on new commits.}

[cubic-dev-ai]

2 issues found across 13 files

Prompt for AI agents (unresolved issues)

Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.


<file name="IslandAppLib/Windows/NotchBarWindow.swift">

<violation number="1" location="IslandAppLib/Windows/NotchBarWindow.swift:55">
P2: `reposition()` uses `NSScreen.main`, which can compute notch metrics/placement from the wrong monitor. Use the window’s current screen first when recalculating layout.</violation>
</file>

<file name="Package.swift">

<violation number="1" location="Package.swift:9">
P2: Avoid hardcoding `/Applications/Xcode.app` to detect Xcode builds; this is path-fragile and can disable `PREVIEWS` in valid Xcode environments.</violation>
</file>

_{Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.}

[cubic-dev-ai]

3 issues found across 13 files (changes from recent commits).

Prompt for AI agents (unresolved issues)

Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.


<file name="IslandAppLib/Views/NotchBar/StatusDot.swift">

<violation number="1" location="IslandAppLib/Views/NotchBar/StatusDot.swift:90">
P2: Guard the first delayed completed-flash callback against stale runs; otherwise a previous flash can cancel a newer flash during quick state changes.</violation>
</file>

<file name="IslandAppLib/Views/Island/IslandRootView.swift">

<violation number="1" location="IslandAppLib/Views/Island/IslandRootView.swift:238">
P2: Click-to-expand can leave a pushed pointing-hand cursor unbalanced because expansion bypasses the collapsed hover-exit pop path.</violation>
</file>

<file name="IslandApp/IslandApp.swift">

<violation number="1" location="IslandApp/IslandApp.swift:99">
P2: Escape handling is wired only to a global key monitor, so Esc collapse is unreliable. Add a local key monitor (and optionally keep global) so Esc works when this app is active and doesn’t depend solely on accessibility-granted global key capture.</violation>
</file>

_{Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.}

[cubic-dev-ai]

P2: Guard the first delayed completed-flash callback against stale runs; otherwise a previous flash can cancel a newer flash during quick state changes.

Prompt for AI agents

Check if this issue is valid — if so, understand the root cause and fix it. At IslandAppLib/Views/NotchBar/StatusDot.swift, line 90:

<comment>Guard the first delayed completed-flash callback against stale runs; otherwise a previous flash can cancel a newer flash during quick state changes.</comment>

<file context>
@@ -1,34 +1,234 @@
+            }
+            let flashStart = Date()
+            lastFlashedAt = flashStart
+            DispatchQueue.main.asyncAfter(deadline: .now() + 0.18) {
+                withAnimation(.easeIn(duration: 0.27)) {
+                    completedScale = 1.0
</file context>

Suggested change

	DispatchQueue.main.asyncAfter(deadline: .now() + 0.18) {
	withAnimation(.easeIn(duration: 0.27)) {
	completedScale = 1.0
	}
	// Allow the timeline to pause after the flash completes.
	DispatchQueue.main.asyncAfter(deadline: .now() + 0.30) {
	if lastFlashedAt == flashStart { lastFlashedAt = nil }
	}
	}
	DispatchQueue.main.asyncAfter(deadline: .now() + 0.18) {
	guard lastFlashedAt == flashStart else { return }
	withAnimation(.easeIn(duration: 0.27)) {
	completedScale = 1.0
	}
	// Allow the timeline to pause after the flash completes.
	DispatchQueue.main.asyncAfter(deadline: .now() + 0.30) {
	if lastFlashedAt == flashStart { lastFlashedAt = nil }
	}
	}

[cubic-dev-ai]

P2: Escape handling is wired only to a global key monitor, so Esc collapse is unreliable. Add a local key monitor (and optionally keep global) so Esc works when this app is active and doesn’t depend solely on accessibility-granted global key capture.

Prompt for AI agents

Check if this issue is valid — if so, understand the root cause and fix it. At IslandApp/IslandApp.swift, line 99:

<comment>Escape handling is wired only to a global key monitor, so Esc collapse is unreliable. Add a local key monitor (and optionally keep global) so Esc works when this app is active and doesn’t depend solely on accessibility-granted global key capture.</comment>

<file context>
@@ -16,57 +16,109 @@ struct IslandApp: App {
+    private func installPanelEventMonitors() {
+        guard panelEventMonitors.isEmpty else { return }
+
+        if let escMonitor = NSEvent.addGlobalMonitorForEvents(matching: .keyDown, handler: { event in
+            // 53 = Escape (kVK_Escape).
+            if event.keyCode == 53 {
</file context>

Suggested change

	if let escMonitor = NSEvent.addGlobalMonitorForEvents(matching: .keyDown, handler: { event in
	// 53 = Escape (kVK_Escape).
	if event.keyCode == 53 {
	Task { @MainActor in IslandCoordinator.shared.collapse() }
	}
	}) {
	panelEventMonitors.append(escMonitor)
	}
	if let escLocalMonitor = NSEvent.addLocalMonitorForEvents(matching: .keyDown, handler: { event in
	// 53 = Escape (kVK_Escape).
	if event.keyCode == 53 {
	Task { @MainActor in IslandCoordinator.shared.collapse() }
	return nil
	}
	return event
	}) {
	panelEventMonitors.append(escLocalMonitor)
	}
	if let escGlobalMonitor = NSEvent.addGlobalMonitorForEvents(matching: .keyDown, handler: { event in
	if event.keyCode == 53 {
	Task { @MainActor in IslandCoordinator.shared.collapse() }
	}
	}) {
	panelEventMonitors.append(escGlobalMonitor)
	}

[cubic-dev-ai]

1 issue found across 1 file (changes from recent commits).

Prompt for AI agents (unresolved issues)

Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.


<file name="IslandAppLib/Views/NotchBar/NotchBarView.swift">

<violation number="1" location="IslandAppLib/Views/NotchBar/NotchBarView.swift:82">
P3: Remove the temporary DEBUG diagnostic background tint from `NotchBarView`; it changes the component’s visual output in debug/previews and can skew UI verification.</violation>
</file>

_{Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.}

[cubic-dev-ai]

You're iterating quickly on this pull request. To help protect your rate limits, cubic has paused automatic reviews on new pushes for now—when you're ready for another review, comment @cubic-dev-ai review.