[IMP] Prevent sneaky people to script their way through#1
Open
rrahir wants to merge 1 commit into
Open
Conversation
sherpal
reviewed
Jan 18, 2022
| private val clickHandler: js.Function1[MouseEvent, _] = { (event: MouseEvent) => | ||
| if (event.istrusted()) { | ||
| mouseClickBus.writer.onNext(event) | ||
| } |
Owner
There was a problem hiding this comment.
Apparently istrusted is not a function and is spelled isTrusted.
So we can replace these lines with
if event.isTrusted then mouseClickBus.writer.onNext(event)
fec67e7 to
281b707
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a really bad contribution as I haven't installed the game, even less tested it but I hope you get the idea :)