nit: reduce deps (and bump rimraf)#15
Open
sir-opti wants to merge 2 commits intoshocknet:mainfrom
Open
Conversation
- changing prepack to prepare directive retains git-sourcing but does not require build tools to be in production deps and call the correct script in actions - rimraf is only needed for build cleaning - typescript is only needed for compiling this helps reducing downstream dependencies
fixes dependency audit reports: - brace-expansion: GHSA-v6h2-p8h4-qcjw - glob: GHSA-5j98-mcp5-4vw2 - minimatch: - GHSA-3ppc-4f35-3m26 - GHSA-7r86-cg39-jmmj - GHSA-23c5-xmqv-rm74
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Minor nit that helps downstream SBOMs stay clean.
Because package
dependenciespropagate down to SDK consumers, bothtypescriptandrimrafare unnecessarily installed as a runtime dependency for downstream users of the SDK (i.e. through including@shocknet/clink-sdkin our owndependencies.)Because of (to my knowledge still not fully solved) npm/cli#1229 making interactions with non-packed git sources crappy when compiled sources are
.gitignored, keeping everything needed fornpm packin dependencies has been a common solution. However, given proper.gitignoreand.npmignore(you have this), usingprepareinstead ofprepackcould be feasible, as explained in thatnpm/cliissue. This would remove package pressure exerted to consuming implementations.95daf27f4:prepacktoprepareand calls the correct script in GH actionsrimrafis only needed for build cleaning, moves it todevDependenciestypescriptis only needed for compiling, moves it todevDependenciesas well060375d7:rimraf@^6.0.1depends on a whole load of things, bump it to^6.1.3which is both cleaner and resolves a ton ofnpm auditcomplaints.Thought that maybe this could help.