Open
Conversation
Curl is not an emacs package, this is removed.
Owner
|
@ethanmoss1 thanks for putting this together and making it an Emacs only package, I love that. I won't be able to test it for a couple days but I'm on-board with merging it and going this direction. I'll test and merge ASAP. Thanks again! |
Author
|
Oh no, thank you! Especially for doing most of the work! It was fun learning the URL package/lib. I might tackle some of the long-term goals soon, so I'll create a pull request when I've had a go. Any issues just shout and I'll get them changed ready for merging. |
This upsets Elpaca as it trys to install url
The function can now check inputs as well as change priority on the message.
The priority should be 1 to 5. and now the checks use a known good string or number
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumped version to 2 as this requires a different library and no need for CURL.
Fixes issue #1, This stops package.el, elpaca and straight from trying to find an emacs package called curl.
If we want i can tackle #2 ?