automate github releases upload based on tags#2
Draft
GabLeRoux wants to merge 10 commits into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey there, related to OpenArena#1 I managed to get releases creation with some actions by first downloading the artifacts from the macos workflow and then uploading it when a tag is pushed.
I'm not sure if there's still something to do, I wasn't too much attentive but felt that the release workflow succeeded before the actual build so it might have used a previous succeeding build, we should confirm this before merging, hence I'm creating this pr as a draft.
Edit: I think I solved it by removing some params and sticking to default. 👍
I tried it as I have a similar issue here:
GabLeRoux/macos-crossover-wine-cloud-builder#25
Also, commits should be squashed, I just tried a few things before it gets to work.
Releases confirmed working here:
https://github.com/GabLeRoux/OpenArena-legacy/releases