feat!: State plugin refactor - #227
Open
Felix Frank (feliopterix) wants to merge 10 commits into
Open
Conversation
…ma to DIVEMaterial, DIVEGeometry and DIVEGeometryType
…ping out of DIVERoot
…ose its root publicly
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## trunk #227 +/- ##
==========================================
- Coverage 99.69% 99.67% -0.02%
==========================================
Files 141 148 +7
Lines 7435 7765 +330
Branches 1723 1802 +79
==========================================
+ Hits 7412 7740 +328
- Misses 23 25 +2 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
1. Why is this change necessary?
The current implementation of the State plugin is deeply integrated in the actual engine code. This decision comes from the initial integration into the Scene Editor in the Shopware Administration, which was the first use-case for Dive.
Now we want to change that: remove the State plugin code from the engine (as much as possible), add a gateway between engine and State plugin, thin down the engine code to load less when State plugin is not used at all.
2. What does this change do, exactly?
EngineGatewayclass to take control of the scene, renderer and so on via actions (and not the engine directly).3. Describe each step to reproduce the issue or behaviour.
4. Please link to the relevant issues (if any).
5. Checklist