feat: move translations to framework concepts#2288
Open
Bojan Rajh (bojanrajh) wants to merge 5 commits into
Open
feat: move translations to framework concepts#2288Bojan Rajh (bojanrajh) wants to merge 5 commits into
Bojan Rajh (bojanrajh) wants to merge 5 commits into
Conversation
Contributor
|
|
Bojan Rajh (bojanrajh)
requested review from
Micha Hobert (Isengo1989) and
Su (sushmangupta)
Contributor
There was a problem hiding this comment.
Pull request overview
Moves the translations concept documentation under the Concepts → Framework → Translations section and updates several guides to reference the new location, including adding a redirect for the old section path.
Changes:
- Added a new
concepts/framework/translations/section (index + fallback guide). - Updated multiple guides to point translation-related links to the new location.
- Added a GitBook redirect from
concepts/translations/toconcepts/framework/translations/.
Reviewed changes
Copilot reviewed 7 out of 9 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| guides/upgrades-migrations/language-pack-migration.md | Updates reference link to the translation handling concept page. |
| guides/upgrades-migrations/extension-translation.md | Updates links to the fallback-language-selection concept page. |
| guides/plugins/plugins/storefront/styling/add-translations.md | Updates fallback-language-selection link to the new concepts path. |
| guides/plugins/plugins/administration/templates-styling/adding-snippets.md | Updates fallback-language-selection link to the new concepts path. |
| guides/plugins/apps/administration/adding-snippets.md | Updates fallback-language-selection link to the new concepts path. |
| concepts/framework/translations/index.md | Adds a new “Translations” landing page under framework concepts. |
| concepts/framework/translations/fallback-language-selection.md | Adds the fallback language selection guide under the new section. |
| concepts/framework/translations/built-in-translation-system.md | Updates internal link to the fallback language selection guide. |
| .gitbook.yaml | Adds redirect from old translations concepts path to the new location. |
Comments suppressed due to low confidence (1)
concepts/framework/translations/built-in-translation-system.md:79
- The link to the fallback language guide is unnecessarily (and incorrectly) routed via
./../../concepts/...even though this page already lives inconcepts/framework/translations/. This relative path will not resolve correctly; link directly to the sibling page instead (e.g.,./fallback-language-selection.md).
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR moves Concepts > Translations into Concepts > Framework > Translations, leaving 4 Concept categories:
Related links
#2265
Checklist
PageRefreferences where relevant..gitbook.yamlif pages were moved, renamed, or deleted..wordlist.txt(and sorted it) if spellcheck flags new legitimate terms.Notes