refactor(cms-base-layer)!: make the package a plain Nuxt layer - #2609
Open
Maciek Kucmus (mkucmus) wants to merge 4 commits into
Open
refactor(cms-base-layer)!: make the package a plain Nuxt layer#2609Maciek Kucmus (mkucmus) wants to merge 4 commits into
Maciek Kucmus (mkucmus) wants to merge 4 commits into
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Refactors @shopware/cms-base-layer to reflect its real usage as a plain Nuxt layer (rather than a Nuxt module + build output), tightening the published surface via an exports map and removing dead build artifacts/config.
Changes:
- Removed the unused Nuxt module entry/build artifacts (
src/index.ts,build.config.ts,index.cjs, stale types). - Adjusted package publishing metadata (
files,exports) and droppedunbuildusage for this package. - Updated layer-local type shims and documentation to match layer consumption via
extends.
Reviewed changes
Copilot reviewed 10 out of 13 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| pnpm-lock.yaml | Removes unbuild from the cms-base-layer importer after dropping the build step. |
| packages/cms-base-layer/vitest.config.ts | Removes vitest aliases that pointed to missing files. |
| packages/cms-base-layer/types/imports.d.ts | Updates #imports shim to re-export built composables types. |
| packages/cms-base-layer/tsconfig.json | Simplifies include/exclude for the layer-only TS program. |
| packages/cms-base-layer/src/index.ts | Deletes the dead Nuxt module implementation. |
| packages/cms-base-layer/README.md | Updates docs to reflect layer auto-import usage and blocked deep imports. |
| packages/cms-base-layer/package.json | Converts package metadata to a plain Nuxt layer (exports, files, scripts/deps cleanup). |
| packages/cms-base-layer/index.cjs | Removes the CommonJS proxy (no longer published/needed). |
| packages/cms-base-layer/components.d.ts | Removes stale global component typings at outdated paths. |
| packages/cms-base-layer/build.config.ts | Removes unbuild configuration now that nothing is bundled. |
| packages/cms-base-layer/AGENTS.md | Updates contributor guidance to reflect “no build step” layer reality. |
| AGENTS.md | Documents that Nuxt layers ship sources as-is and have no build step. |
| .changeset/tidy-carrots-shake.md | Adds a major changeset documenting the breaking packaging/import changes. |
Files not reviewed (1)
- pnpm-lock.yaml: Generated file
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Maciek Kucmus (mkucmus)
requested review from
Maciej D (mdanilowicz) and
Patryk Tomczyk (patzick)
August 5, 2026 15:37
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Makes
@shopware/cms-base-layera plain Nuxt layer. Closes #2163src/index.ts,build.config.ts,index.cjs,dist). It registered a component folder that moved toapp/long ago, so it could not work.buildanddevscripts and theunbuilddev dependency. Nothing is left to bundle.files(listedhelpersandapp.config.tsthat do not exist) and added anexportsmap.components.d.tsand two vitest aliases pointing at missing files.types/imports.d.tsnow uses the built@shopware/composablestypes instead of its sources.Breaking: the
exportsmap blocks deep imports like@shopware/cms-base-layer/app/components/SwProductCard.vue, andindex.cjs/distare no longer published. Consume the package withextends: ["@shopware/cms-base-layer"].Type of change
Breaking change (fix or feature that would cause existing functionality to not work as expected)
ToDo's
Additional context
Verified: layer tests/lint/typecheck, repo-wide typecheck (68 tasks),
vue-demo-storevue-tsc and production build, CI build command, andnpm packdiff vs main (onlyindex.cjsleaves the tarball).