fix(shopware): omit optional null fields in spec.network and spec.container#270
Open
DeividsP-P wants to merge 2 commits into
Open
fix(shopware): omit optional null fields in spec.network and spec.container#270DeividsP-P wants to merge 2 commits into
DeividsP-P wants to merge 2 commits into
Conversation
…tainer
Move field keys inside {{- with }} guards so fields are omitted entirely
when not configured, rather than rendering as null. This prevents CRD
schema validation failures for typed fields (object, string, array).
Fields fixed in spec.network:
- ingressLabels
- gatewayName
- gatewaySectionName
- gatewayNamespace
- gatewayAnnotations
- gatewayLabels
Fields fixed in spec.container:
- imagePullSecrets
- topologySpreadConstraints
- nodeSelector
- affinity
- labels
- annotations
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes null field rendering for optional fields in
spec.networkandspec.containerthat cause CRD schema validation failures when the fields are not configured.Problem
When optional fields are not set, templates render the field key with a null value:
The
StoreCRD rejects null values for typed fields, producing errors such as:Fix
Move field keys inside
{{- with }}guards so the entire field is omitted when not configured.spec.network:
ingressLabels,gatewayName,gatewaySectionName,gatewayNamespace,gatewayAnnotations,gatewayLabelsspec.container:
imagePullSecrets,topologySpreadConstraints,nodeSelector,affinity,labels,annotations