fix: icon script errors#1149
Open
Alastair Fraser (alastair-simon) wants to merge 6 commits into
Open
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
Alastair Fraser (alastair-simon)
changed the title
Alastair Fraser (alastair-simon)
force-pushed
the
fix/icon-kit-script
branch
from
145f319 to
162486b
Compare
Alastair Fraser (alastair-simon)
requested a review
from Arnold Stoba (arnoldstoba)
Arnold Stoba (arnoldstoba)
approved these changes
Jun 8, 2026
@shopware-ag/meteor-admin-sdk
@shopware-ag/meteor-component-library
@shopware-ag/create-meteor-extension
@shopware-ag/meteor-icon-kit
@shopware-ag/meteor-prettier-config
@shopware-ag/stylelint-plugin-meteor
@shopware-ag/meteor-tokens
commit: |
Copilot stopped work on behalf of
Alastair Fraser (alastair-simon) due to an error
June 8, 2026 13:15
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
This pull request updates the icon processing workflow and improves error handling. The main changes include updating GitHub Actions dependencies, patching a dependency for CI compatibility, and improving error tracking in the icon script.
Why?
The pipeline consistently failed, so no new icons could be added with the action.
How?
CI/CD workflow updates:
.github/workflows/update-icons.yml: Updated several GitHub Actions to their latest major versions for improved stability and security, includingactions/checkout,actions/setup-node, andpeter-evans/create-pull-request..github/workflows/update-icons.yml: Added a step to patchsvgo-autocropin CI to launch Puppeteer with--no-sandboxflags, ensuring compatibility in CI environments.Error handling improvements:
packages/icon-kit/src/index.ts: Enhanced error handling in the icon optimization process by collecting failed icons with their errors, logging failures, and throwing an error if any icons fail to process. This provides clearer feedback during CI runs.This is a temporary fix, as the package svgo-autocrop needs proper patching.