fix: adjusted font bundling which now skips vite bundling#1172
Open
Arnold Stoba (arnoldstoba) wants to merge 2 commits into
Open
fix: adjusted font bundling which now skips vite bundling#1172Arnold Stoba (arnoldstoba) wants to merge 2 commits into
Arnold Stoba (arnoldstoba) wants to merge 2 commits into
Conversation
… relies on manually importing woff2 font files only
Arnold Stoba (arnoldstoba)
requested review from
Alastair Fraser (alastair-simon) and
Jannis Leifeld (jleifeld)
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Adjusted font loading by skipping vite bundling for fonts
Why?
Vite library mode will always inline all assets which leads to it bundling the fonts into base64, which increases the bundle size unnecessarily. With this change we are loading the actual font files instead and relying purely on css. We are required to add a small call in the build step to copy the font assets into the dist folder manually to avoid vite to handle and inline those.
How?
Custom build script copies assets, paths of fonts are set in the css - the final usage path for consumers stays the same - it's still font.css
Testing?
Tested it manually and the output dist from the build contains the correct files and paths.