Re-embed Icon kit @ DevHub#57
Open
Bojan Rajh (bojanrajh) wants to merge 7 commits into
Open
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
Nils Haberkamp (Haberkamp)
suggested changes
Feb 26, 2024
Contributor
|
Hi Bojan Rajh (@bojanrajh) 👋 Is this PR still needed? |
Contributor
Author
|
Fabian Hüske (@fabianhueske) Generally, yes. This branch is mounted in DevHub, but there's also a fork for shopware.design (not affected by this PR). Edit: DevHub healthcheck workflow is triggered for approved requests with |
Fabian Hüske (fabianhueske)
requested a review
from Nils Haberkamp (Haberkamp)
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
docs:env,docs:linkanddocs:previewshortcuts/commands for Icon kitWhy?
So we can switch Icon kit docs to the new monorepo.
How?
Testing?
There's a healthcheck workflow in #51 .
Screenshots (optional)
Anything Else?
We can remove the workflow from
developer-portalif updatingmeta.jsonbecomes part of the release process (I see it's part of the repo now).