feat: cleanup done exec / debug CR after graceperiod

[Tom Bojer (tombojer)]

No description provided.

[Copilot]

Pull request overview

Adds automatic cleanup of successful (done) StoreExec and StoreDebugInstance custom resources after a configurable grace period, exposed via operator config and Helm values. This helps reduce CR noise/accumulation while allowing operators time to inspect completed resources.

Changes:

• Add CleanupGracePeriod support to StoreExecReconciler and StoreDebugInstanceReconciler, deleting successful one-shot CRs after the grace period (with requeue scheduling when not yet due).
• Expose grace period as SUCCESSFUL_CR_CLEANUP_GRACE_PERIOD (config + Helm) with default 1h and allow disabling via 0.
• Add unit tests covering cleanup eligibility, deletion timing, and disabled behavior.

Reviewed changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated 3 comments.

Show a summary per file

File	Description
internal/controller/successful_cleanup_test.go	New tests for successful-CR cleanup behavior (StoreExec + StoreDebugInstance).
internal/controller/storeexec_controller.go	Adds grace-period-based cleanup for successful StoreExec CRs.
internal/controller/storedebuginstance_controller.go	Adds grace-period-based cleanup for successful StoreDebugInstance CRs.
internal/config/config.go	Adds SuccessfulCRCleanupGracePeriod to operator config/env parsing.
helm/values.yaml	Adds Helm value for cleanup grace period with docs.
helm/templates/deployment.yaml	Wires Helm value into env var SUCCESSFUL_CR_CLEANUP_GRACE_PERIOD.
cmd/main.go	Passes configured grace period into both reconcilers.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.