SG-40910 Fix banner text contrast on macOS in Adobe apps#132
Merged
julien-lang merged 4 commits intomasterfrom Feb 5, 2026
Merged
SG-40910 Fix banner text contrast on macOS in Adobe apps#132julien-lang merged 4 commits intomasterfrom
julien-lang merged 4 commits intomasterfrom
Conversation
The banner info message displayed at the top of the Loader after triggering actions (e.g., "Open File") had poor contrast on macOS, especially in Photoshop and After Effects. The text appeared in beige color on a blue background, making it nearly unreadable. The issue was caused by using palette().text() for the text color, which is designed for use on the base background color, not on a highlight background. Changed to use palette().highlightedText() instead, which is specifically designed for text displayed on highlight-colored backgrounds, ensuring proper contrast across all platforms and applications. Fixes text readability in banner messages on macOS in Adobe DCCs.
There was a problem hiding this comment.
Pull request overview
This PR fixes a contrast issue with banner text in the Loader on macOS, particularly in Adobe applications like Photoshop and After Effects, where text appeared in beige on blue making it difficult to read.
Changes:
- Updated banner text color to use the appropriate palette role for highlighted backgrounds
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #132 +/- ##
=======================================
Coverage 19.72% 19.72%
=======================================
Files 35 35
Lines 2794 2794
=======================================
Hits 551 551
Misses 2243 2243
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
carlos-villavicencio-adsk
approved these changes
Feb 2, 2026
…nner-text-contrast-macos
julien-lang
changed the base branch from
master
to
ticket/SG-40910-pre-commit
…-banner-text-contrast-macos
julien-lang
deleted the
ticket/SG-40910-fix-banner-text-contrast-macos
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The banner info message displayed at the top of the Loader after triggering actions had poor contrast on macOS, especially in Photoshop and After Effects. The text appeared in beige color on a blue background, making it nearly unreadable.
Solution
Changed the banner text color from
palette().text()topalette().highlightedText(). ThehighlightedText()color role is specifically designed for text displayed on highlight-colored backgrounds, ensuring proper contrast across all platforms.Testing
Fixes: SG-40910