Skip to content

SG-40910 Update Pre-commit/Black#133

Merged
julien-lang merged 1 commit intomasterfrom
ticket/SG-40910-pre-commit
Feb 5, 2026
Merged

SG-40910 Update Pre-commit/Black#133
julien-lang merged 1 commit intomasterfrom
ticket/SG-40910-pre-commit

Conversation

@julien-lang
Copy link
Member

This pull request focuses on code quality improvements and dependency updates. The main changes include updating pre-commit hook dependencies, consistently unpacking tuples without parentheses for Pythonic style, and minor formatting adjustments throughout the codebase.

@julien-lang julien-lang requested a review from Copilot February 4, 2026 19:15
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates pre-commit hook dependencies and applies Black formatting changes to improve code consistency across the codebase. The updates include upgrading pre-commit-hooks from v5.0.0 to v6.0.0 and Black from 25.1.0 to 26.1.0, along with automated formatting adjustments.

Changes:

  • Updated pre-commit hook versions in .pre-commit-config.yaml
  • Removed unnecessary parentheses from tuple unpacking assignments throughout the codebase (more Pythonic style)
  • Consolidated multi-line function calls and string formatting to single lines where appropriate
  • Cleaned up whitespace inconsistencies (removed extra blank lines, adjusted line breaks)

Reviewed changes

Copilot reviewed 16 out of 16 changed files in this pull request and generated no comments.

Show a summary per file
File Description
.pre-commit-config.yaml Updated pre-commit-hooks to v6.0.0 and Black to v26.1.0
python/tk_multi_loader/utils.py Consolidated multi-line error logging statement
python/tk_multi_loader/model_latestpublish.py Removed parentheses from tuple unpacking
python/tk_multi_loader/dialog.py Removed parentheses from tuple unpacking and consolidated multi-line statements
python/tk_multi_loader/delegate_publish_thumb.py Removed parentheses from tuple unpacking
python/tk_multi_loader/delegate_publish_list.py Removed parentheses from tuple unpacking
python/tk_multi_loader/api/manager.py Removed extra blank line
hooks/tk-shell_actions.py Added blank line after docstring
hooks/tk-photoshop_actions.py Added blank line after docstring
hooks/tk-nuke_actions.py Added blank line after docstring and removed parentheses from tuple unpacking
hooks/tk-motionbuilder_actions.py Added blank line after docstring and removed parentheses from tuple unpacking
hooks/tk-maya_actions.py Consolidated multi-line function call
hooks/tk-mari_actions.py Added blank line after docstring
hooks/tk-houdini_actions.py Added blank line after docstring
hooks/tk-flame_actions.py Added blank line after docstring
hooks/tk-3dsmaxplus_actions.py Added blank line after docstring and removed parentheses from tuple unpacking

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@julien-lang julien-lang marked this pull request as ready for review February 4, 2026 19:21
@julien-lang julien-lang requested a review from a team February 4, 2026 19:21
@codecov
Copy link

codecov bot commented Feb 4, 2026

Codecov Report

❌ Patch coverage is 10.00000% with 9 lines in your changes missing coverage. Please review.
✅ Project coverage is 19.72%. Comparing base (319e494) to head (7716320).
⚠️ Report is 29 commits behind head on master.

Files with missing lines Patch % Lines
python/tk_multi_loader/dialog.py 20.00% 4 Missing ⚠️
python/tk_multi_loader/model_latestpublish.py 0.00% 2 Missing ⚠️
python/tk_multi_loader/delegate_publish_list.py 0.00% 1 Missing ⚠️
python/tk_multi_loader/delegate_publish_thumb.py 0.00% 1 Missing ⚠️
python/tk_multi_loader/utils.py 0.00% 1 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (319e494) and HEAD (7716320). Click for more details.

HEAD has 16 uploads less than BASE
Flag BASE (319e494) HEAD (7716320)
16 0
Additional details and impacted files
@@             Coverage Diff             @@
##           master     #133       +/-   ##
===========================================
- Coverage   77.09%   19.72%   -57.38%     
===========================================
  Files          33       35        +2     
  Lines        2633     2794      +161     
===========================================
- Hits         2030      551     -1479     
- Misses        603     2243     +1640     
Flag Coverage Δ
Linux 19.72% <10.00%> (?)
Python-3.10 19.72% <10.00%> (?)
Python-3.11 19.72% <10.00%> (?)
Python-3.9 19.72% <10.00%> (?)
Windows 19.72% <10.00%> (?)
macOS 19.72% <10.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

@carlos-villavicencio-adsk carlos-villavicencio-adsk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd suggest to disable codecov so we don't block this task.

@julien-lang julien-lang merged commit f5cc9e1 into master Feb 5, 2026
22 of 23 checks passed
@julien-lang julien-lang deleted the ticket/SG-40910-pre-commit branch February 5, 2026 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants