Skip to content

low battery alert#2

Open
abancp wants to merge 6 commits intoshreyasskdev:mainfrom
abancp:main
Open

low battery alert#2
abancp wants to merge 6 commits intoshreyasskdev:mainfrom
abancp:main

Conversation

@abancp
Copy link
Copy Markdown

@abancp abancp commented May 14, 2025

No description provided.

@abancp
Copy link
Copy Markdown
Author

abancp commented May 14, 2025

show a alert when batery on 15% and discharging

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unneccesory

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unneccesory

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Repeatation of code

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Animation time should not be changed unless its necessory. Should include result with screenrecord

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Animation is overused.

make-colors.sh Outdated
Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bash files are prohibited.

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

An explanation would be appreciated

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Too many files for colors

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should not be in upstream branch.

styles/colors.sh Outdated
Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks boring and don't match the existing look. Wallpaper based dynamic color mode deciding would be welcomed.

@shreyasskdev
Copy link
Copy Markdown
Owner

Resolve conflicts

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants