Allow providing a custom request factory#73
Closed
andig wants to merge 1 commit intoshurcooL:mainfrom
andig:patch-1
Closed
Allow providing a custom request factory#73andig wants to merge 1 commit intoshurcooL:mainfrom andig:patch-1
andig wants to merge 1 commit intoshurcooL:mainfrom
andig:patch-1
Conversation
This was referenced Jul 25, 2021
|
how do I provide my own request factory? |
Author
|
I've kept it simple. After creating the client you would simply replace |
Author
|
Ping @dmitshur |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR allows customizing the requests sent for APIs that require additional headers.
Replace #47, #48, #49, #64, #68.
This is not the most beautiful solution but offers the highest amount of customizing the request with the least amount of added lines of code. Making the request factory a private member and optional
NewClientparameter would be a further option./cc @dmitshur