Skip to content

fix: ensure full theme compatibility and text visibility#80

Open
KGFCH2 wants to merge 56 commits into
shwetap3000:mainfrom
KGFCH2:fix/theme-visibility
Open

fix: ensure full theme compatibility and text visibility#80
KGFCH2 wants to merge 56 commits into
shwetap3000:mainfrom
KGFCH2:fix/theme-visibility

Conversation

@KGFCH2
Copy link
Copy Markdown

@KGFCH2 KGFCH2 commented May 13, 2026

This PR establishes a robust design system that guarantees visibility and accessibility across themes.

@shwetap3000 you can close #79 issue after merging this PR.

@KGFCH2
Copy link
Copy Markdown
Author

KGFCH2 commented May 17, 2026

image

@KGFCH2 KGFCH2 force-pushed the fix/theme-visibility branch from 608c594 to 1525ed8 Compare May 18, 2026 16:28
@KGFCH2 KGFCH2 force-pushed the fix/theme-visibility branch from 1525ed8 to 49c0da2 Compare May 18, 2026 19:01
KGFCH2 added 17 commits May 19, 2026 00:32
…with icons

- Replace all emojis with lucide-react icons:
  - FilterPanel: Replace ⚛️, 🔩, 💨, ⚡, ✨ with Atom, Zap, Wind, Droplet, Sparkles
  - QuizMode: Replace ⚗️ with Beaker, 🔥 with Flame, ✅❌ with CheckCircle/XCircle
  - App.js: Replace ⚗️ with Beaker icon

- Fix text visibility in both light and dark modes:
  - PeriodicTable.css: Change hardcoded text colors to use CSS variables
  - QuizMode.css: Update modal and all text to use theme variables
  - Trends.css: Convert hardcoded dark colors to use theme variables
  - CompareElements.css: Fix select and card styling for theme consistency
  - AssistantWindow and other components already use variables

- Ensure proper contrast ratios:
  - All text now respects light/dark theme via --text-color variable
  - Muted text uses --text-muted variable
  - Panel backgrounds use --panel-bg variable
  - Proper borders use --glass-border variable
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Text visibility and theme inconsistency in Light/Dark modes

1 participant