Feat/text visibility icons#87
Open
KGFCH2 wants to merge 69 commits into
Open
Conversation
…with icons - Replace all emojis with lucide-react icons: - FilterPanel: Replace ⚛️, 🔩, 💨, ⚡, ✨ with Atom, Zap, Wind, Droplet, Sparkles - QuizMode: Replace ⚗️ with Beaker, 🔥 with Flame, ✅❌ with CheckCircle/XCircle - App.js: Replace ⚗️ with Beaker icon - Fix text visibility in both light and dark modes: - PeriodicTable.css: Change hardcoded text colors to use CSS variables - QuizMode.css: Update modal and all text to use theme variables - Trends.css: Convert hardcoded dark colors to use theme variables - CompareElements.css: Fix select and card styling for theme consistency - AssistantWindow and other components already use variables - Ensure proper contrast ratios: - All text now respects light/dark theme via --text-color variable - Muted text uses --text-muted variable - Panel backgrounds use --panel-bg variable - Proper borders use --glass-border variable
Author
|
@shwetap3000 you can close #86 issue after merging this PR. Thank you... |
Owner
|
@KGFCH2 Submitting a PR before issue assignment will not be considered |
Author
|
@shwetap3000 I was giving PR after issue. |
…with icons - Replace all emojis with lucide-react icons: - FilterPanel: Replace ⚛️, 🔩, 💨, ⚡, ✨ with Atom, Zap, Wind, Droplet, Sparkles - QuizMode: Replace ⚗️ with Beaker, 🔥 with Flame, ✅❌ with CheckCircle/XCircle - App.js: Replace ⚗️ with Beaker icon - Fix text visibility in both light and dark modes: - PeriodicTable.css: Change hardcoded text colors to use CSS variables - QuizMode.css: Update modal and all text to use theme variables - Trends.css: Convert hardcoded dark colors to use theme variables - CompareElements.css: Fix select and card styling for theme consistency - AssistantWindow and other components already use variables - Ensure proper contrast ratios: - All text now respects light/dark theme via --text-color variable - Muted text uses --text-muted variable - Panel backgrounds use --panel-bg variable - Proper borders use --glass-border variable
KGFCH2
force-pushed
the
feat/text-visibility-icons
branch
from
314a52f to
4163f6b
Compare
…odic-Table-Explorer into fix/theme-visibility
…2/Periodic-Table-Explorer into feat/text-visibility-icons
KGFCH2
force-pushed
the
feat/text-visibility-icons
branch
2 times, most recently
from
7315726 to
4686520
Compare
KGFCH2
force-pushed
the
feat/text-visibility-icons
branch
from
4686520 to
862cbeb
Compare
Owner
|
@KGFCH2 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Confirming all texts and icons are clearly visible in light/dark mode throughout each componenets.