chore: trigger PR check#1
Open
EmmyCodes234 wants to merge 16 commits into
Open
Conversation
…and tests - Add prSastEngine.ts: TypeScript SAST engine with scanFiles, detectLanguage, computeFingerprint, evaluateThreshold pure functions - Add prSastRules.ts: 45 regex-based SAST rules converted from YAML covering JavaScript, Python, Java, Go, and Rust - Add prScanWorkflow.ts: Convex Node.js action orchestrating full PR scan lifecycle (token acquisition, file fetching, scanning, results storage, GitHub Check Run posting) with 120s timeout and error handling - Wire http.ts webhook handler to schedule runPrScan on PR opened/synchronize - Add 7 property-based tests and 96 unit tests (103 total, all passing) - Install @types/node and fix all TypeScript errors across convex project - Fix pre-existing type errors in auth.ts, http.ts, and test files
# Conflicts: # convex/convex/prSastEngine.ts
… crash Move requireGitHubAppEnv, generateAppJwt, and getInstallationToken into githubAppNode.ts using Node native crypto.createSign instead of Web Crypto. This prevents esbuild from pulling atob/crypto.subtle into the Node runtime, which caused 'Invalid character at atob' when parsing the RSA private key. - githubAppNode.ts: add exported auth functions using Node crypto - prScanWorkflow.ts: import from githubAppNode instead of githubApp - Update test mocks to reference githubAppNode
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Brief description of the change.
Why
Motivation and context. Link related issues:
Closes #...How
Implementation approach (if non-obvious).
Checklist
cargo test --workspace)cargo fmt --all)cargo clippy --workspace -- -D warnings)