Conversation
rutuHaladkar
requested review from
AdityaPatil22,
atharv-g-kulkarni,
hybridx,
pshirsat443 and
rohit-bharmal
❌ Deploy Preview for cfp-portal failed.
|
pages/forgot-password/index.vue
Outdated
| const email = ref('') | ||
| const error = ref('') | ||
|
|
||
| const emailRegex = /^[^\s@]+@[^\s@]+\.[^\s@]+$/ |
There was a problem hiding this comment.
I can se there is validation for email in each file can you move all the validation to util
There was a problem hiding this comment.
i have moved the validation to util
pages/forgot-password/index.vue
Outdated
| <input v-model="email" type="text" placeholder="Enter your email" > | ||
| <span>{{ error }}</span> | ||
|
|
||
| <button type="submit">Send Reset Link</button> |
There was a problem hiding this comment.
can you use pf elements across all the three files
There was a problem hiding this comment.
i have used pf elements and pushed in latest commit
pages/forgot-password/index.vue
Outdated
|
|
||
| <button type="submit">Send Reset Link</button> | ||
|
|
||
| <router-link to="/login" class="back-link">Back to Login</router-link> |
There was a problem hiding this comment.
why are you using in Nuxt ? I guess is available.
There was a problem hiding this comment.
I have replaced this with NuxtLink
| <div> | ||
| <h1>Deafult Header</h1> | ||
|
|
||
| <slot /> |
There was a problem hiding this comment.
layout is use for common skeleton if you are just using slot I think there is no need of layout can render pages directly
There was a problem hiding this comment.
Still I can see there are no changes in this files
pages/forgot-password/index.vue
Outdated
| } | ||
|
|
||
| error.value = '' | ||
| alert('Reset link sent to your email!') |
There was a problem hiding this comment.
i have used pf elements and pushed in latest commit
pages/login/index.vue
Outdated
|
|
||
| <button type="submit">Login</button> | ||
|
|
||
| <a href="/forgot-password" class="forgot-link">Forgot password?</a> |
There was a problem hiding this comment.
I have replaced this with NuxtLink and pushed in latest commit
pages/login/index.vue
Outdated
| errors.value = newErrors | ||
|
|
||
| if (Object.keys(newErrors).length === 0) { | ||
| alert('Login successful!') |
pages/signup/index.vue
Outdated
| // } catch (err) { | ||
| // alert(err?.data?.message || 'Registration failed.') | ||
| // } | ||
| alert('Registration successful!') |
|
Please rebase |
pages/forgot-password/index.vue
Outdated
| const PUBLIC_KEY = 'pAWKcYpKic8yzixYp' | ||
|
|
||
| function handleSubmit() { | ||
| if (!email.value.trim()) { |
There was a problem hiding this comment.
we can create the email validation function in the util itself and use wherever required i can see its repeating in each file
pages/forgot-password/index.vue
Outdated
|
|
||
| const SERVICE_ID = 'service_r6tk9ii' | ||
| const TEMPLATE_ID = 'template_2dmls66' | ||
| const PUBLIC_KEY = 'pAWKcYpKic8yzixYp' |
There was a problem hiding this comment.
better to move this thing in the env
pages/forgot-password/index.vue
Outdated
| <pf-card class="form-card"> | ||
| <h1>Reset your Password</h1> | ||
| <form @submit.prevent="handleSubmit"> | ||
| <input v-model="email" type="text" placeholder="Enter your email"> |
There was a problem hiding this comment.
you can look the replace this too with pf elements
rutuHaladkar
force-pushed
the
feature/login-signup
branch
from
5fdaa49 to
6d46baf
Compare
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
4 participants
No description provided.