feat(typeahead): support typeaheadLoading via input#1637
Draft
spike-rabbit wants to merge 1 commit intomainfrom
Draft
feat(typeahead): support typeaheadLoading via input#1637spike-rabbit wants to merge 1 commit intomainfrom
typeaheadLoading via input#1637spike-rabbit wants to merge 1 commit intomainfrom
Conversation
The current `optionSource` approach is not feasible for the filtered-search in its current situation. So we need an alternative. This is also flagged as experimental, hoping that with ongoing filtered-search refactoring, we may get rid of that.
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
The pull request refactors the loading state management within the si-typeahead component and directive. It introduces a new typeaheadLoading input property to allow external control over the loading state and a optionSourceLoading signal to manage internal loading from the option source. These two signals are combined into a new loading computed signal, which is then used in the component's template to display loading indicators. The previous internal typeaheadLoading signal has been removed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current
optionSourceapproach is not feasible for the filtered-search in its current situation. So we need an alternative.This is also flagged as experimental, hoping that with ongoing filtered-search refactoring, we may get rid of that.
Documentation.
Examples.
Dashboards Demo.
Playwright report.
Coverage Reports: