feat(dashboards-ng): event bus for widget communication#1647
Open
chintankavathia wants to merge 11 commits intomainfrom
Open
feat(dashboards-ng): event bus for widget communication#1647chintankavathia wants to merge 11 commits intomainfrom
chintankavathia wants to merge 11 commits intomainfrom
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces a well-designed SiEventBus service for inter-widget communication, which is a significant and valuable feature. The implementation thoughtfully supports both Angular and non-Angular contexts by leveraging shared state on the window object, making it suitable for microfrontend architectures. The documentation and tests are comprehensive. My review includes suggestions to improve type safety by adhering to the project's style guide.
e0ac73d to
ca9ea13
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduces
EventBusservice to emit and subscribe events with data between widgets.Also introduces
getEventBusInstanceutil with separate entry point@siemens/dashboards-ng/event-busto allow non angular widgets to utilize same service.Usage
Documentation.
Examples.
Dashboards Demo.
Playwright report.
Coverage Reports: