test(dashboards-ng): add e2e for webcomponent widget#1651
Draft
chintankavathia wants to merge 1 commit intomainfrom
Draft
test(dashboards-ng): add e2e for webcomponent widget#1651chintankavathia wants to merge 1 commit intomainfrom
chintankavathia wants to merge 1 commit intomainfrom
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request adds an end-to-end test for a web component-based widget in the dashboards demo. The test implementation is good, but it uses fixed timeouts which can lead to flaky tests. I've suggested removing these and relying on Playwright's auto-waiting capabilities to make the test more robust and efficient.
chintankavathia
force-pushed
the
test/e2e/dashboards/webcomponent
branch
from
75fdeae to
d4570a8
Compare
chintankavathia
force-pushed
the
test/e2e/dashboards/webcomponent
branch
from
d4570a8 to
c903362
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Documentation.
Examples.
Dashboards Demo.
Playwright report.
Coverage Reports: