chore(eslint): disable no deprecated rule in libs#1662
chore(eslint): disable no deprecated rule in libs#1662akashsonune wants to merge 1 commit intomainfrom
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request disables the @typescript-eslint/no-deprecated ESLint rule for several library packages. While the changes are simple, they lack a description explaining the rationale. Disabling this rule can introduce risks by allowing the use of deprecated APIs, which can lead to future maintenance issues and breaking changes. I've added comments on the specific changes suggesting to either address the underlying deprecations or, if that's not feasible right now, to document the reason for disabling the rule in the PR description and create a follow-up issue to re-enable it.
|
Why do want to disable those rules? |
they sort of prevent us deprecating anything in our libs. rule only make sense for our examples where we don't want to promote usage of deprecated stuff. internally we still need to use them for backward compatibility. |
|
@spike-rabbit WDYT? This prevents me from using the deprecated ones for ex - #1656 btw,we also disabled the rule in element-ng. Maybe we can keep it as a warning? |
|
In general I would be in favor to keep them, and disable in the files when we on purpose use deprecated stuff. @siemens/siemens-element WDYT? |
3 participants
Documentation.
Examples.
Dashboards Demo.
Playwright report.
Coverage Reports: