refactor(filtered-search): extract free text input#1667
refactor(filtered-search): extract free text input#1667spike-rabbit wants to merge 1 commit intomainfrom
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
The pull request successfully extracts the free text input into a new standalone component, SiFilteredSearchInputComponent. This refactoring significantly improves the modularity and separation of concerns within the SiFilteredSearchComponent, making it leaner and more focused on orchestration. The changes align well with modern Angular best practices, including the extensive use of signals, computed properties, and functional input/output declarations. The removal of direct DOM manipulation and ChangeDetectorRef usage from the parent component further enhances maintainability and performance. Overall, this is a well-executed refactoring that improves the codebase's structure and adherence to best practices.
projects/element-ng/filtered-search/si-filtered-search-input.component.ts
Show resolved
Hide resolved
This extracts to search-input to a separate component. The goal is to keep the root component free of interaction logic.
spike-rabbit
force-pushed
the
refactor/filtered-search/extract-input-component
branch
from
9d9b9f5 to
345fa0d
Compare
spike-rabbit
requested review from
a team,
chintankavathia and
spliffone
as code owners
1 participant
This extracts to search-input to a separate component. The goal is to keep the root component free of interaction logic.
Documentation.
Examples.
Dashboards Demo.
Playwright report.
Coverage Reports: