Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces a new ESLint configuration, strictLinterOptions, which enforces reporting unused eslint-disable directives as errors. This configuration is then applied globally by integrating it into the main eslint.config.js and subsequently importing and spreading it into the defineConfig calls of all project-specific ESLint configurations.
chintankavathia
force-pushed
the
chore/lint/strict-linter-options
branch
from
803c1cd to
a1d1686
Compare
chintankavathia
force-pushed
the
chore/lint/strict-linter-options
branch
from
a1d1686 to
211793e
Compare
| export default defineConfig(...tsConfig, ...templateConfig); | ||
| export const strictLinterOptions = defineConfig({ | ||
| linterOptions: { | ||
| reportUnusedDisableDirectives: 'error' |
There was a problem hiding this comment.
I guess, you can directly do this in siemens/lint
There was a problem hiding this comment.
It will not work if I just put it in existing lint configs and extend. this means to move it to siemens/lint also it requires to be a separate package entry something like @siemens/eslint-config-linter and to me it feels too much overhead just for one config. WDYT?
2 participants
Documentation.
Examples.
Dashboards Demo.
Playwright report.
Coverage Reports: